[core] Bump git-utils: 5.7.1 => ^5.7.3
#772
Conversation
🤯 Wow. |
There was a problem hiding this comment.
The description of how this reduces the size of the final app bundle sounds absolutely reasonable (makes sense to me), and this seems like a nice easy "win"/improvement.
Bonus points: The diff in git-utils does indeed look completely non-meaningful to our use. It's CI config files for that repo to use only that were changed, along with the package's README.md.
So this doesn't change anything other than giving us fewer dependencies that we can presumably load more efficiently and have a slightly smaller app. 👍 Very cool!
(The nan bump would have been actively good, but it's neutral since they already used caret semver and we no-doubt have newer nan than their bumped minimum anyway. But just as much as this doesn't help us in any way, it also doesn't hurt or do effectively anything to us, really.)
|
Thanks again for the approval @DeeDeeG! And glad we can to the same conclusion about the changes, and with that I'll go ahead and merge this one! |
This PR bumps the version of
git-utilsused within the core editor.I've gone ahead and added the carrot to allow it to auto update if needed (But
git-utilsis our own library, so I can't really see that happening in an unexpected way).The reason for this PR is rather simple, but one I've had my eye on for quite some time.
In our distributed binaries of Pulsar there are two different versions of
git-utilsincluded in the compressedasarfile:git-utils@5.7.1: This is what we have had the version pinned to within the core editorgit-utils@5.7.3: This is what was allowed to be installed viascandalas that library usesgit-utils@^5.6.0While some duplication isn't a big deal, the
git-utilslibrary is 85.00 MB for each copy. Meaning that this simple, minor difference in the installed versions ofgit-utilscauses an increase of our binaries by ~170MB. Which when we considerv1.110.0when installed on Windows is1.07GBmeans that this tiny change can get us just under a 1GB install. (We should end up installing at about ~985MB after this change)And for anyone still nervous about any functional changes to the editor, here's the full diff between these versions. Which literally seems to be some repo cleanup, GitHub Actions, and sorting the dependencies. In other words should be zero functional difference.
As for the last justification, it's simply bumping versions, which is always good when they don't have breaking changes, like here.